On Mon, Apr 23, 2018 at 11:36:20AM -0500, Aaron Sawdey wrote: > This also affects gcc 7 and is fixed by the same patch. I've tested the > backport to 7 on ppc64le and it causes no new fails. OK for backport to > 7 (and 6 if it's also needed there)?
Yes please (for both). Thanks! Segher > On Fri, 2018-04-13 at 15:37 -0500, Aaron Sawdey wrote: > > Per the discussion on the 83660, I've come to a minimal patch to > > prevent this. Basically marking the vec_extract tree as having side > > effects later makes sure that it gets all the cleanup points it needs > > so that gimplify_cleanup_point_expr () is happy. Also because > > vec_insert puts a MODIFY_EXPR in there, it has side effects and this > > problem will not occur. > > > > Doing bootstrap/regtest on ppc64le with -mcpu=power7 since that is > > where this issue arises. OK for trunk if everything passes? > > > > Thanks, > > Aaron > > > > > > 2018-04-13 Aaron Sawdey <acsaw...@linux.ibm.com> > > > > PR target/83660 > > * config/rs6000/rs6000-c.c > > (altivec_resolve_overloaded_builtin): Mark > > vec_extract expression as having side effects to make sure it > > gets > > a cleanup point. > > > > 2018-04-13 Aaron Sawdey <acsaw...@linux.ibm.com> > > > > PR target/83660 > > * gcc.target/powerpc/pr83660.C: New test.
