On May 14, 2018 2:30:27 PM GMT+02:00, Prathamesh Kulkarni <prathamesh.kulka...@linaro.org> wrote: >On 14 May 2018 at 15:06, Richard Biener <rguent...@suse.de> wrote: >> On Mon, 14 May 2018, Prathamesh Kulkarni wrote: >> >>> On 14 May 2018 at 14:46, Richard Biener <rguent...@suse.de> wrote: >>> > On Mon, 14 May 2018, Prathamesh Kulkarni wrote: >>> > >>> >> Hi, >>> >> The attached patch tries to fix PR85734, by gating on >>> >> !function_always_visible_to_compiler_p. >>> >> Bootstrap+test in progress on x86_64. >>> >> OK to commit if passes ? >>> > >>> > This looks redundant - suggest_attribute does that very same check >>> > but warn_function_malloc passes it 'false' as known_finite >>> > (warn_function_noreturn passes it true for example). >>> Indeed, thanks for pointing it out. >>> > >>> > So I suggest to simply pass true as that arg. >>> Is the attached version OK to commit after bootstrap+test ? >> >> Yes. >Also on a related bug PR85562, should we change the wording of >suggest_attribute for malloc >to omit the text "if it is known to return normally" ?
Yes. Richard. >Thanks, >Prathamesh >> Richard. >> >>> Thanks, >>> Prathamesh >>> > >>> > Richard >>> > >>> >> Thanks, >>> >> Prathamesh >>> >> >>> > >>> > -- >>> > Richard Biener <rguent...@suse.de> >>> > SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Graham >Norton, HRB 21284 (AG Nuernberg) >>> >> >> -- >> Richard Biener <rguent...@suse.de> >> SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Graham >Norton, HRB 21284 (AG Nuernberg)
