Richard Sandiford wrote: > - if (allocno_class != ALL_REGS) > + if (allocno_class != POINTER_AND_FP_REGS) > return allocno_class; > > - if (best_class != ALL_REGS) > + if (best_class != POINTER_AND_FP_REGS) > return best_class; > > mode = PSEUDO_REGNO_MODE (regno);
> I think it'd be better to use !reg_class_subset_p (POINTER_AND_FP_REGS, ...) > instead of ... != POINTER_AND_FP_REGS, since this in principle still applies > to ALL_REGS too. > > FWIW, the patch looks good to me with that change. How does reg_class_subset_p help? In my testing I didn't see ALL_REGS ever used (and I don't believe it's possible to get it with SVE either). And it's not obvious without looking at the implementation whether subset here means strict subset or not, so it would obfuscate the clear meaning of the existing patch. Wilco
