Hi Jackson

On 11/07/18 17:48, Jackson Woodruff wrote:
Hi Sudi,

On 07/10/2018 02:29 PM, Sudakshina Das wrote:
Hi Jackson

On Tuesday 10 July 2018 09:37 AM, Jackson Woodruff wrote:
Hi all,

This patch resolves PR86014.  It does so by noticing that the last load may clobber the address register without issue (regardless of where it exists in the final ldp/stp sequence). That check has been changed so that the last register may be clobbered and the testcase (gcc.target/aarch64/ldp_stp_10.c) now passes.

Bootstrap and regtest OK.

OK for trunk?




2018-06-25  Jackson Woodruff  <jackson.woodr...@arm.com>

        PR target/86014
        * config/aarch64/aarch64.c (aarch64_operands_adjust_ok_for_ldpstp):
        Remove address clobber check on last register.

This looks good to me but you will need a maintainer to approve it. The only thing I would add is that if you could move the comment on top of the for loop
to this patch. That is, keep the original
/* Check if the addresses are clobbered by load.  */
in your [1/2] and make the comment change in [2/2].
Thanks, change made.  OK for trunk?

Looks good to me but you will need approval from
a maintainer to commit it!




Reply via email to