Hi Alexandre, > -----Original Message----- > From: gcc-patches-ow...@gcc.gnu.org <gcc-patches-ow...@gcc.gnu.org> > On Behalf Of Alexandre Oliva > Sent: Thursday, July 26, 2018 08:46 > To: Tamar Christina <tamar.christ...@arm.com> > Cc: Joseph Myers <jos...@codesourcery.com>; Jeff Law > <l...@redhat.com>; gcc-patches@gcc.gnu.org; nd <n...@arm.com>; > bonz...@gnu.org; d...@redhat.com; nero...@gcc.gnu.org; > ralf.wildenh...@gmx.de > Subject: Re: [PATCH][GCC][front-end][build-machinery][opt-framework] > Allow setting of stack-clash via configure options. [Patch (4/6)] > > On Jul 25, 2018, Tamar Christina <tamar.christ...@arm.com> wrote: > > > gcc/ > > 2018-07-25 Tamar Christina <tamar.christ...@arm.com> > > > PR target/86486 > > * configure.ac: Add stack-clash-protection-guard-size. > > * doc/install.texi: Document it. > > * config.in (DEFAULT_STK_CLASH_GUARD_SIZE): New. > > * params.def: Update comment for guard-size. > > (PARAM_STACK_CLASH_PROTECTION_GUARD_SIZE, > > PARAM_STACK_CLASH_PROTECTION_PROBE_INTERVAL): Update > description. > > * configure: Regenerate. > > Thanks. No objections from me. I don't see any use of the new config knob, > though; assuming it's in a subsequent patch, I guess this one is fine, but I'm > not sure I'm entitled to approve it.
Yup it's in a subsequent AArch64 patch. That's no problem, Jeff still has to review the other front-end patch so I'll have to wait for approval there anyway. Thanks for the review and comments! Regards, Tamar > > -- > Alexandre Oliva, freedom fighter https://FSFLA.org/blogs/lxo > Be the change, be Free! FSF Latin America board member > GNU Toolchain Engineer Free Software Evangelist
