On 07/27/2018 03:44 PM, Eric Botcazou wrote: >> Apropos of the discussion about improving the docs for >> TARGET_CUSTOM_FUNCTION_DESCRIPTORS in the context of the C-SKY port >> submission, >> >> https://gcc.gnu.org/ml/gcc-patches/2018-07/msg01454.html >> >> here is the patch I've come up with based on reading the source. Is >> this technically accurate? Any suggestions on how to improve it further? > > ""Define this hook to 0 if the target implements custom support" > > "custom" was precisely chosen to distinguish this kind of descriptors from > the > standard descriptors used on IA-64 or HP-PA, so it's contradictory. Moreover > I would really start with the "custom" case and not the standard case as was > originally written, the "custom" case being the common case for targets. > > I'm not really convinced by the substitution misalignment -> tag either, but > if others find the new version more understandable, then OK with me. I think the new version is an improvement, but I don't think it's ideal due to the issues noted above.
We're trying to distinguish between the ABI mandated function descriptors and those generated internally for supporting nested functions. Wordsmithing that into the docs might make things clearer. I'm not sure how to express that clearly in the name of the target hook though. jeff
