On Sun, Sep 16, 2018 at 01:00:21PM +0200, Andreas Schwab wrote: > On Sep 03 2018, co...@sdf.org wrote: > > > config/tls.m4: Remove extra parentheses > > There are no extra parentheses. >
For the benefit of the discussion, I've added the more minimal version of the patch. This is a weird configure test because of the parens. It's not wrong because its wrongness is compensated for later. So maybe it's a matter of opinion. But probably this is the intended generated autoconf output.
diff --git a/config/tls.m4 b/config/tls.m4 index 4e170c8d6ae..b9b363d8a80 100644 --- a/config/tls.m4 +++ b/config/tls.m4 @@ -104,7 +104,7 @@ AC_DEFUN([GCC_CHECK_CC_TLS], [ gcc_cv_have_cc_tls, [ AC_COMPILE_IFELSE([__thread int a; int b; int main() { return a = b; }], [gcc_cv_have_cc_tls=yes], [gcc_cv_have_cc_tls=no])] - )]) + ) if test "$enable_tls $gcc_cv_have_cc_tls" = "yes yes"; then AC_DEFINE(HAVE_CC_TLS, 1, [Define to 1 if the target assembler supports thread-local storage.]) diff --git a/libgcc/configure b/libgcc/configure index 79068536175..8ccb700da0f 100644 --- a/libgcc/configure +++ b/libgcc/configure @@ -5304,6 +5304,11 @@ rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext fi { $as_echo "$as_me:${as_lineno-$LINENO}: result: $gcc_cv_have_cc_tls" >&5 $as_echo "$gcc_cv_have_cc_tls" >&6; } + if test "$enable_tls $gcc_cv_have_cc_tls" = "yes yes"; then + +$as_echo "#define HAVE_CC_TLS 1" >>confdefs.h + + fi set_have_cc_tls= if test "$enable_tls $gcc_cv_have_cc_tls" = "yes yes"; then set_have_cc_tls="-DHAVE_CC_TLS"