On 10/17/18 6:45 PM, Jakub Jelinek wrote:
As mentioned in the PR, for use in headers for the same reason like we
support __aligned__ form next to aligned (user defining such a macro) this
patch allows to mangle the scope the same way.

In addition to that, it fixes an ICE, where because we didn't canonicalize
the attribute name in [[using gnu : __aligned__(4)]] we'd ICE on some of the
GNU attributes.

Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?

OK.

Is a partial backport (just add
       attr_id = canonicalize_attr_name (attr_id);
in the else if (attr_ns) case plus the non-__gnu__ lines from the testcase)
ok for 7/8 release branches where it ICEs?

If a backport seems useful, go ahead and backport the whole patch.

Jason

Reply via email to