Thomas Preudhomme <thomas.preudho...@linaro.org> writes:
> And now with the patch. My apologies for the omission.
>
> Best regards,
>
> Thomas
> On Tue, 23 Oct 2018 at 12:08, Thomas Preudhomme
> <thomas.preudho...@linaro.org> wrote:
>>
>> Hi,
>>
>> Currently, dg-cmp-results will not print anything for a test that was
>> not run before, even if it is a FAIL now. This means that when
>> contributing a code change together with a testcase in the same commit
>> one must run dg-cmp-results twice: once to check for regression on a
>> full testsuite run and once against the new testcase with -v -v. This
>> also prevents using dg-cmp-results on sum files generated with
>> test_summary since these would not contain PASS.
>>
>> This patch changes dg-cmp-results to print NA->FAIL changes by default.
>>
>> ChangeLog entry is as follows:
>>
>> *** contrib/ChangeLog ***
>>
>> 2018-10-23 Thomas Preud'homme <thomas.preudho...@linaro.org>
>>
>> * dg-cmp-results.sh: Print NA-FAIL changes at default verbosity.
>>
>> Is this ok for trunk?
>>
>> Best regards,
>>
>> Thomas
>
> From ab4272a15bdd8931ef683e234e7dd2e0d038df5f Mon Sep 17 00:00:00 2001
> From: Thomas Preud'homme <thomas.preudho...@linaro.org>
> Date: Tue, 23 Oct 2018 11:54:51 +0100
> Subject: [PATCH] dg-cmp-results: display NA->FAIL by default
>
> Hi,
>
> Currently, dg-cmp-results will not print anything for a test that was
> not run before, even if it is a FAIL now. This means that when
> contributing a code change together with a testcase in the same commit
> one must run dg-cmp-results twice: once to check for regression on a
> full testsuite run and once against the new testcase with -v -v. This
> also prevents using dg-cmp-results on sum files generated with
> test_summary since these would not contain PASS.
>
> This patch changes dg-cmp-results to print NA->FAIL changes by default.
>
> ChangeLog entry is as follows:
>
> *** contrib/ChangeLog ***
>
> 2018-10-23 Thomas Preud'homme <thomas.preudho...@linaro.org>
>
> * dg-cmp-results.sh: Print NA-FAIL changes at default verbosity.
>
> Is this ok for trunk?
>
> Best regards,
>
> Thomas
> ---
> contrib/dg-cmp-results.sh | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/contrib/dg-cmp-results.sh b/contrib/dg-cmp-results.sh
> index 821d557a168..921a9b9ca28 100755
> --- a/contrib/dg-cmp-results.sh
> +++ b/contrib/dg-cmp-results.sh
> @@ -137,8 +137,11 @@ function drop() {
> function compare(st, nm) {
> old = peek()
> if (old == 0) {
> - # This new test wasn't run last time.
> - if (verbose >= 2) printf("NA->%s:%s\n", st, nm)
> + # This new test wasn't run last time.
> + if(st == "FAIL" || verbose >= 2) {
> + # New test fails or we want all changes
> + printf("NA->%s:%s\n", st, nm)
> + }
Probably also worth doing this for UNRESOLVED, where some markup problem
stops a test from doing anything useful.
OK with that change, thanks.
Richard
