On Sun, Nov 11, 2018 at 7:20 PM Bernhard Reutner-Fischer <rep.dot....@gmail.com> wrote: > > On Sun, 11 Nov 2018 16:02:33 +0800 > "bin.cheng" <bin.ch...@linux.alibaba.com> wrote: > > Quick observation unrelated to the real patch. > > I think the coding style mandates to use the type itself and not the > underlying structure. > > I know there are alot of places from before our switch to C++ that > still use enum tree_code or enum machine_mode, but new code should > adhere to the style please. > > So: s/enum tree_code/tree_code/g Thanks very much for reminding, I forgot the switch when writing the patch, will update along with changes for other reviews.
Thanks, bin > > thanks,
