On Mon, Nov 12, 2018 at 11:54:37AM +0000, Sam Tebbs wrote: > On 11/08/2018 08:34 PM, Segher Boessenkool wrote: > > > On Thu, Nov 08, 2018 at 03:44:44PM +0000, Sam Tebbs wrote: > >> Does your patch fix the incorrect generation of "scvtf s1, s1"? I was > >> looking at the issue as well and don't want to do any overlapping work. > > I don't know. Well, there are no incorrect code issues I know of at all > > now; but you mean that it is taking an instruction more than you would > > like to see, I suppose? > > Yes, I am referring to the extra instruction being generated. In my > opinion is incorrect code generation since the intention is that it > shouldn't be generated, and shouldn't based on the relevant code and > patterns implemented.
That is not what incorrect code means; it is a "missed optimisation", instead. Anyway, does it now do what you want? (PR87763 btw) Segher
