On 11/13/18 4:08 PM, Jakub Jelinek wrote:
> On Tue, Nov 13, 2018 at 04:01:56PM +0100, Martin Liška wrote:
>> On 11/12/18 1:07 PM, Jakub Jelinek wrote:
>>> On Mon, Nov 12, 2018 at 01:03:41PM +0100, Martin Liška wrote:
>>>> The patch reject usage of the mentioned options.
>>>>
>>>> Ready for trunk?
>>>> Thanks,
>>>> Martin
>>>>
>>>> gcc/ChangeLog:
>>>>
>>>> 2018-11-12 Martin Liska <mli...@suse.cz>
>>>>
>>>> PR sanitizer/87930
>>>> * config/i386/i386.c (ix86_option_override_internal): Error
>>>> about usage -mabi=ms and -fsanitize={,kernel-}address.
>>>
>>> Please add testcases for this.
>>
>> Done in attached patch.
>>
>> Can this be changed through attribute too?
>>
>> No.
>>
>> I'm going to install the patch.
>
> Can you please move the test to gcc.dg/asan/ and guard with
> { i?86-*-* x86_64-*-* } && lp64 ?
> I don't think we don't want -fsanitize=address tests outside of /asan/
> subdirs where we guard them on the availability of asan.
>
> Jakub
>
Sure, there's a patch I've just tested.
Martin
>From 89aa27fb5d816c7d854cd77ba0f157d69bc927f7 Mon Sep 17 00:00:00 2001
From: marxin <mli...@suse.cz>
Date: Tue, 13 Nov 2018 16:23:08 +0100
Subject: [PATCH] Move a test-case to a proper folder.
ChangeLog:
2018-11-13 Martin Liska <mli...@suse.cz>
* pr87930.c: Move from gcc/testsuite/gcc.target/i386/
into gcc/testsuite/gcc.dg/asan/.
---
gcc/testsuite/{gcc.target/i386 => gcc.dg/asan}/pr87930.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
rename gcc/testsuite/{gcc.target/i386 => gcc.dg/asan}/pr87930.c (68%)
diff --git a/gcc/testsuite/gcc.target/i386/pr87930.c b/gcc/testsuite/gcc.dg/asan/pr87930.c
similarity index 68%
rename from gcc/testsuite/gcc.target/i386/pr87930.c
rename to gcc/testsuite/gcc.dg/asan/pr87930.c
index e9cf29c221a..4f8e6999fde 100644
--- a/gcc/testsuite/gcc.target/i386/pr87930.c
+++ b/gcc/testsuite/gcc.dg/asan/pr87930.c
@@ -1,4 +1,4 @@
-/* { dg-do compile { target lp64 } } */
+/* { dg-do compile { target { { i?86-*-* x86_64-*-* } && lp64 } } } */
/* { dg-options "-fsanitize=address -mabi=ms" } */
int i;
--
2.19.1
