On Tue, 2018-11-13 at 14:54 -0500, Mike Gulick wrote: > 2018-11-13 Mike Gulick <mgul...@mathworks.com>
[...] > * gcc/diagnostic-core.h (num_digits): Add extern definition. FWIW you moved the decl to diagnostic.h, but didn't update the above ChangeLog entry. [...] > diff --git a/libcpp/location-example.txt b/libcpp/location- > example.txt > index 14b5c2e284a..dc448b0493e 100644 > --- a/libcpp/location-example.txt > +++ b/libcpp/location-example.txt You're going to need to regenerate this file again; I touched many of the same lines as your patch does, in r266085 (sorry). Other than the nits above, this looks good to me (once you have your contribution paperwork in place). Thanks Dave
