On Wed, 26 Sep 2018 11:21:33 -0700 Cesar Philippidis <ce...@codesourcery.com> wrote:
> This is an old gomp4 patch that updates the location of the clause for > acc enter/exit data. Apparently, it didn't impact any test cases. Is > this OK for trunk or should we drop it from OG8? > > I bootstrapped and regtested it for x86_64 Linux with nvptx > offloading. At least at a glance, there is no actual change to behaviour given in this patch, it is just an extremely minor cleanup. I.e. in: location_t loc = pragma_tok->location; [...] SET_EXPR_LOCATION (stmt, pragma_tok->location); the variable "loc" is used in the SET_EXPR_LOCATION instead. It doesn't look like anything could mutate either variable in the interim. So, OK, or shall we just drop this? (Joseph?) Thanks, Julian