On Fri, 30 Nov 2018 17:55:17 +0800 Chung-Lin Tang <chunglin_t...@mentor.com> wrote:
> On 2018/7/21 6:07 AM, Cesar Philippidis wrote: > > This is another old gomp4 patch that corrects a bug where the > > runtime was passing the wrong offset for subarray data to the > > accelerator. The original description of this patch can be found > > here <https://gcc.gnu.org/ml/gcc-patches/2016-08/msg01676.html> > > > > I bootstrapped and regtested on x86_64/nvptx. Is it OK for trunk? > > > > Thanks, > > Cesar > > > > Hi Thomas, this patch should be within your maintainership area now. > > I think this patch is pretty obvious; this is what the 'offset' field > of struct target_var_desc is supposed to be used for, and is in line > with other sites throughout target.c. > > I do think it might be better to use a more succinct form like as > attached, you may consider which form better suits your taste when > you apply it. This one will be superseded by the attach/detach patch, I think (where the additional offset is added also, via calling "gomp_map_val". HTH, Julian
