On 26/11/2018 21:13, Mike Stump wrote:
On Nov 26, 2018, at 12:04 PM, Mike Stump <mikest...@comcast.net> wrote:

I'll Ok the signal one, if you prefer it over a dummy signal routine.  Though, 
would be nice for you to add signal if possible/reasonable.

Oh, and my long term thinking on signal is that logically, it's fine to have:

#if __has_include("signal.h")
   signal(...);
#endif

This doesn't work here because we have signal.h (and indeed "signal").

The problem is that the function doesn't work (actually, it doesn't link, because "kill" is missing).

I've solved the problem by adding a machine-specific stub function in Newlib, so we can drop this portion of the patch from the testsuite now.

Andrew

Reply via email to