thanks a lot for fixing this issue.

Qing
> On Dec 7, 2018, at 7:07 AM, Rainer Orth <r...@cebitec.uni-bielefeld.de> wrote:
> 
> Hi Qing,
> 
>>> On Nov 28, 2018, at 9:52 AM, Jan Hubicka <hubi...@ucw.cz> wrote:
>>> 
>>>> 
>>>> 2018-11-20  qing zhao  <qing.z...@oracle.com>
>>>> 
>>>>    * cif-code.def (EXTERN_LIVE_ONLY_STATIC): New CIF code.
>>>>    * common.opt: Add -flive-patching flag.
>>>>    * doc/invoke.texi: Document -flive-patching.
>>>>    * flag-types.h (enum live_patching_level): New enum.
>>>>    * ipa-inline.c (can_inline_edge_p): Disable external functions from
>>>>    inlining when flag_live_patching is LIVE_PATCHING_INLINE_ONLY_STATIC.
>>>>    * opts.c (control_options_for_live_patching): New function.
>>>>    (finish_options): Make flag_live_patching incompatible with flag_lto.
>>>>    Control IPA optimizations based on different levels of 
>>>>    flag_live_patching.
>>>> 
>>>> gcc/testsuite/ChangeLog:
>>>> 
>>>> 2018-11-20  qing zhao  <qing.z...@oracle.com>
>>>> 
>>>>    * gcc.dg/live-patching-1.c: New test.
>>>>    * gcc.dg/live-patching-2.c: New test.
>>>>    * gcc.dg/live-patching-3.c: New test.
>>>>    * gcc.dg/tree-ssa/writeonly-3.c: New test.
>>>>    * gcc.target/i386/ipa-stack-alignment-2.c: New test.
> [...]
>>> Patch is OK,
>> 
>> thanks for the review.
>> 
>> I will commit the patch very soon.
> 
> the new gcc.target/i386/ipa-stack-alignment-2.c testcase FAILs on
> Solaris/x86:
> 
> FAIL: gcc.target/i386/ipa-stack-alignment-2.c scan-assembler sub.*%.sp
> 
> Like ipa-stack-alignment.c, it needs -fomit-frame-pointer.  Fixed as
> follows, tested on i386-pc-solaris2.11 and x86_64-pc-linux-gnu, 32 and
> 64-bit each.  Installed on mainline.
> 
>       Rainer
> 
> -- 
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University
> 
> 
> 2018-12-06  Rainer Orth  <r...@cebitec.uni-bielefeld.de>
> 
>       * gcc.target/i386/ipa-stack-alignment-2.c: Add
>       -fomit-frame-pointer to dg-options.
> 
> # HG changeset patch
> # Parent  580b8c24b018674f1ffd56a9c672129f746682c5
> Build gcc.target/i386/ipa-stack-alignment-2.c with -fomit-frame-pointer
> 
> diff --git a/gcc/testsuite/gcc.target/i386/ipa-stack-alignment-2.c 
> b/gcc/testsuite/gcc.target/i386/ipa-stack-alignment-2.c
> --- a/gcc/testsuite/gcc.target/i386/ipa-stack-alignment-2.c
> +++ b/gcc/testsuite/gcc.target/i386/ipa-stack-alignment-2.c
> @@ -1,5 +1,5 @@
> /* { dg-do compile } */
> -/* { dg-options "-flive-patching -O" } */
> +/* { dg-options "-flive-patching -O -fomit-frame-pointer" } */
> 
> typedef struct {
>   long a;

Reply via email to