On 12/14/18 12:50 PM, Jakub Jelinek wrote:
> Hi!
>
> The avx512f-vfixupimms{s,d}-2.c testcases were miscompiled with -mavx512vl.
> The problem is that there are separate instructions (e.g. vfixupimmsd vs.
> vfixupimmpd), each of those have different behavior, the first one is
> TARGET_AVX512F, the latter TARGET_AVX512VL, but the 128-bit version of the
> latter used identical RTL pattern to the vfixupimmsd instruction and was
> defined earlier.
>
> Fixed by using different UNSPEC number for the scalar vs. vector ones.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
>
> 2018-12-14 Jakub Jelinek <ja...@redhat.com>
>
> PR target/88489
> * config/i386/sse.md (UNSPEC_SFIXUPIMM): New unspec enumerator.
> (avx512f_sfixupimm<mode><mask_name><round_saeonly_name>): Use it
> instead of UNSPEC_FIXUPIMM.
>
> * gcc.target/i386/avx512vl-vfixupimmsd-2.c: New test.
> * gcc.target/i386/avx512vl-vfixupimmss-2.c: New test.
OK
jeff