On Wed, Jan 16, 2019 at 8:37 AM Tom de Vries <tdevr...@suse.de> wrote: > > On 16-01-19 02:15, Ian Lance Taylor wrote: > > On Tue, Dec 11, 2018 at 2:15 AM Tom de Vries <tdevr...@suse.de> wrote: > >> > >> Factor out the common handling of DW_AT_abstract_origin and > >> DW_AT_specification from read_function_entry and read_referenced_name. > >> > >> 2018-12-10 Tom de Vries <tdevr...@suse.de> > >> > >> * dwarf.c (read_referenced_name_1): New function. Factor out of > >> ... > >> (read_referenced_name): ... here, and ... > >> (read_function_entry): ... here. > > > >> +static const char *read_referenced_name (struct dwarf_data *, struct unit > >> *, > >> + uint64_t, > >> backtrace_error_callback, > >> + void *); > >> + > > > > We don't need this declaration. Only add a static declaration if > > there is a forward reference. > > > > > > We need this static declaration because there's a forward reference to > read_referenced_name in read_referenced_name_1.
Whoops, sorry. This patch is OK. Thanks. Ian
