On Wed, 23 Jan 2019 at 22:14, H.J. Lu <hjl.to...@gmail.com> wrote:
>
> On Wed, Jan 23, 2019 at 12:50 PM Joseph Myers <jos...@codesourcery.com> wrote:
> >
> > On Wed, 23 Jan 2019, H.J. Lu wrote:
> >
> > > + fesetround (FE_DOWNWARD);
> > > + float fs = s128;
> > > + if (fs != -0x1p+127)
> > > + abort ();
> > > + double ds = s128;
> > > + if (ds != -0x1p+127)
> > > + abort ();
> >
> > This definitely needs #ifdef FE_DOWNWARD; even just limited to glibc
> > configurations, there are soft-float 64-bit configurations with no support
> > for rounding modes other than to-nearest. Likewise for the other tests
> > using rounding modes other than FE_TONEAREST. OK with that change.
> >
> > It's possible it will turn out a new effective-target is needed for fenv.h
> > support, if there are still configurations people are testing with that
> > lack fenv.h at all.
> >
>
> This is the patch I am checking in.
>
Hi,
The new tests fail to compile on aarch64-elf:
fatal error: fenv.h: No such file or directory
The attached small patch adds
/* { dg-require-effective-target fenv_exceptions } */
to them.
OK?
Christophe
> Thanks.
>
> --
> H.J.
2019-01-24 Christophe Lyon <christophe.l...@linaro.org>
* gcc.dg/torture/fp-int-convert-timode-1.c: Add missing
fenv_exceptions effective target.
* gcc.dg/torture/fp-int-convert-timode-2.c: Likewise.
* gcc.dg/torture/fp-int-convert-timode-3.c: Likewise.
* gcc.dg/torture/fp-int-convert-timode-4.c: Likewise.
diff --git a/gcc/testsuite/gcc.dg/torture/fp-int-convert-timode-1.c
b/gcc/testsuite/gcc.dg/torture/fp-int-convert-timode-1.c
index d6454fa..8cadc1f 100644
--- a/gcc/testsuite/gcc.dg/torture/fp-int-convert-timode-1.c
+++ b/gcc/testsuite/gcc.dg/torture/fp-int-convert-timode-1.c
@@ -2,6 +2,7 @@
float. */
/* { dg-do run } */
/* { dg-require-effective-target int128 } */
+/* { dg-require-effective-target fenv_exceptions } */
/* { dg-options "-frounding-math" } */
#include <fenv.h>
diff --git a/gcc/testsuite/gcc.dg/torture/fp-int-convert-timode-2.c
b/gcc/testsuite/gcc.dg/torture/fp-int-convert-timode-2.c
index dbfa481..ef97c1a 100644
--- a/gcc/testsuite/gcc.dg/torture/fp-int-convert-timode-2.c
+++ b/gcc/testsuite/gcc.dg/torture/fp-int-convert-timode-2.c
@@ -2,6 +2,7 @@
float. */
/* { dg-do run } */
/* { dg-require-effective-target int128 } */
+/* { dg-require-effective-target fenv_exceptions } */
/* { dg-options "-frounding-math" } */
#include <fenv.h>
diff --git a/gcc/testsuite/gcc.dg/torture/fp-int-convert-timode-3.c
b/gcc/testsuite/gcc.dg/torture/fp-int-convert-timode-3.c
index 63a305e..63f68fc 100644
--- a/gcc/testsuite/gcc.dg/torture/fp-int-convert-timode-3.c
+++ b/gcc/testsuite/gcc.dg/torture/fp-int-convert-timode-3.c
@@ -2,6 +2,7 @@
float. */
/* { dg-do run } */
/* { dg-require-effective-target int128 } */
+/* { dg-require-effective-target fenv_exceptions } */
/* { dg-options "-frounding-math" } */
#include <fenv.h>
diff --git a/gcc/testsuite/gcc.dg/torture/fp-int-convert-timode-4.c
b/gcc/testsuite/gcc.dg/torture/fp-int-convert-timode-4.c
index e716109..acf1ce3 100644
--- a/gcc/testsuite/gcc.dg/torture/fp-int-convert-timode-4.c
+++ b/gcc/testsuite/gcc.dg/torture/fp-int-convert-timode-4.c
@@ -2,6 +2,7 @@
float. */
/* { dg-do run } */
/* { dg-require-effective-target int128 } */
+/* { dg-require-effective-target fenv_exceptions } */
/* { dg-options "-frounding-math" } */
#include <fenv.h>
