On Wed, 23 Jan 2019, Tamar Christina wrote: > This patch adds the documentation for Stack clash protection and > Armv8.3-a support to changes.html for GCC 9.
Some additional notes, all minor, for consideration before you commit. + The probing interval/guard size can be set by using + <code>--param stack-clash-protection-guard-size=12|16</code>. + The value of this parameter must be in bytes represented as a power of two. + The only two supported values for this parameter are 12 and 16 being + 4Kb (2^12) and 64Kb (2^16) respectively. This one keeps making me think every time I read it. What do you think of changing the second and third sentences to "The two supported values for this paramter are 12 (for a 4KiB size, 2^12) and 16 (for a 64KiB size, 2^16)." or something like that? Shorter and about the same contents? (Note, uppercase B or we'd refer to bits.) + The Armv8.3-A complex number instructions are now supported via intrinsics + when the option <code>-march=armv8.3-a</code> or equivalent is specified. + For the half-precision floating-point variants of these instructions use the + architecture extension flag <code>+fp16</code>, e.g. + <code>-march=armv8.3-a+fp16</code>. + + The intrinsics are defined by the ACLE specification. Note that these two visual paragraphs in HTML source will be merged into just one unless you add <p>...</p> around the two. Just pointing it out. + <li> + The Armv8.3-A complex number instructions are now supported via intrinsics + when the option <code>-march=armv8.3-a</code> or equivalent is specified. + For the half-precision floating-point variants of these instructions use the + architecture extension flag <code>+fp16</code>, e.g. + <code>-march=armv8.3-a+fp16</code>. + + The intrinsics are defined by the ACLE specification. + </li> I guess this duplication is hard to avoid between Arm and AArch64? Gerald
