On Fri, Feb 08, 2019 at 10:02:27AM -0500, Michael Ploujnikov wrote:
> On 2019-02-07 3:09 p.m., Jakub Jelinek wrote:
> > On Thu, Feb 07, 2019 at 03:04:21PM -0500, Michael Ploujnikov wrote:
> >> 2019-02-07 Michael Ploujnikov <michael.ploujni...@oracle.com>
> >>
> >> PR middle-end/89150
> >> * bitmap.c (test_bitmap_tree_marking): New test.
> >> (NOT_NULL_OR_GARBAGE): For shortening
> >> test_bitmap_tree_marking.
> >> (bitmap_c_tests): Add test_bitmap_tree_marking.
> >
> > Could you do that instead in a plugin in the testsuite?
> > I mean, the patch is adding garbage collection roots, so it will not affect
> > just -fself-tests run, but also any time the compiler will do GC.
> >
> > Jakub
> >
>
> I'm not sure what I would need to do to get gengtype to process a test
> plugin source file and I can't find examples of this.
>
> Instead, shouldn't I just do something like what's at the bottom of
> gcc/ggc-tests.c and not worry about the extra root added to
> gt-bitmap.h?
No, instead ggc-tests.c should be moved into a plugin too. You can run
gengtype from within *.exp and the additional advantage is that you test how
plugins work better.
Jakub
