Hi Iain,
> On Tue, 27 Nov 2018 at 23:28, Rainer Orth <r...@cebitec.uni-bielefeld.de>
> wrote:
>>
>> As mentioned in passing in PR d/87864, libgphobos.so currently fails to
>> link before Solaris 11.4. Until then, you needed to link with -lsocket
>> -lnsl for the networking functions, in S11.4 they were merged into libc.
>>
>> To fix this, I've adapted the check from libgo/configure.ac, for the
>> moment just moving it into an autoconf macro, reindenting it, renaming
>> the variables for the new location, and removing the check for sendfile
>> which isn't used in libphobos.
>>
>> With that patch (and the one from PR d/87864 to provide
>> __start_minfo/__stop_minfo when ld does not), I could bootstrap with
>> --enable-libphobos on i386-pc-solaris2.11 with gas and
>> sparc-sun-solaris2.11 with as on both S11.3 and S11.4. On the former,
>> libsocket and libnsl were properly detected and linked into
>> libgdruntime.so and libgphobos.so, leaving no undefined symbols, while
>> on the latter nothing more than libc is needed.
>>
>> Ok for mainline?
>>
>
> Hi,
>
> Sorry, somehow I missed this and other libphobos related patches.
>
> I see no problem with this if still needed, thanks.
it is on any Solaris release before 11.4. I still test 11.3 which at
least receives occasional updates. Solaris 10 is affected as well, but
given that it's already deprecated, support will be removed in GCC 10
and there are a couple of additional problems there (PR d/88238), I
think it's a better use of everyone's time to just ignore it.
Committed now.
Thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
