On 3/19/19 3:52 PM, Jakub Jelinek wrote:
> On Tue, Mar 19, 2019 at 09:02:27AM +0100, Martin Liška wrote:
>> 2019-03-18  Martin Liska  <mli...@suse.cz>
>>
>>      PR middle-end/89737
>>      * predict.c (combine_predictions_for_bb): Empty likely_edges and
>>      unlikely_edges if there's an edge that belongs to both these sets.
> 
> I admit I don't know this code at all, just wonder if if you find
> an intersection between likely_edges and unlikely_edges, couldn't you just
> remove the intersection from both, rather than all other edges too?

Having a contradict edge makes any assumption about the likeliness of the
others misleading. Plus it's very rare case this happens.

I'm going to install the patch.
Thanks,
Martin

> 
>       Jakub
> 

Reply via email to