On 25.04.19 22:07, Andreas Tobler wrote:
On 18.03.19 22:28, Andreas Tobler wrote:
On 18.03.19 22:22, Jeff Law wrote:
On 3/17/19 2:40 PM, Andreas Tobler wrote:
Hi all,

this patch adds support for multilib on x86_64-unknown-freebsd*
The multilibs are 32-bit.

This patch is functionality tested on gcc8 and gcc9. Test suite testing
is a bit tricky since the FreeBSD dynamic linker handles both, the
32-bit and the 64-bit binaries. So, if I have a 64-bit libgcc in the
LD_LIBRARY_PATH the test fails.
I tweaked the build tree and removed the 64-bit libgcc to test the
32-bit binaries built. So far it looks good. Need to find a way to
extend the testsuite to handle this situation.

Any comments about it are welcome.

Also, when would be the best time to commit this patch? Afair trunk is
in stage4, right?
The patch itself only affects x86_64-unknown-freebsd.

TIA,
Andreas

2019-03-17  Andreas Tobler  <andre...@gcc.gnu.org>

       * config/i386/freebsd64.h: Add bits for 32-bit multilib support.
       * config/i386/t-freebsd64: New file.
       * config.gcc: Add the t-freebsd64 for multilib support.


stage4 is supposed to be regression fixes only, so it's difficult to
make a case for this patch to get into gcc-9.

I'd say defer to gcc-10.

Ok, fine with me.
Once gcc-10 opens, I will commit this patch also to all open and active
branches.

Commit to branch gcc8 done.

Andreas

Reply via email to