Hi Arnaud,

>> Tested on x86_64-pc-linux-gnu installing both to a local filesystem and
>> an NFSv3 filesystem.
>> 
>> Ok for mainline (and the gcc-9 and gcc-8 branches eventually)?
>
> No, this is not OK.
>
> I'd rather keep the simple current logic and either stick to cp -p, or
> use a proper $(INSTALL_whatever) as done elsewhere rather than adding more
> kludges.

how do you mean, `proper $(INSTALL_whatever)'?

I've run the cp -p under strace, which shows

fgetxattr(3, "system.posix_acl_access", 0x7fff96829fd0, 132) = -1 ENODATA (No 
data available)
fstat(3, {st_mode=S_IFREG|0644, st_size=35368, ...}) = 0
fsetxattr(4, "system.posix_acl_access", 
"\2\0\0\0\1\0\6\0\377\377\377\377\4\0\4\0\377\377\377\377 
\0\4\0\377\377\377\377", 28, 0) = -1 EOPNOTSUPP (Operation not supported)

i.e. it tries to determine an extended attribute, is told there's none,
tries to set that none on the destination and chokes if that doesn't
work.  Seems pretty insane to me.

This is cp from coreutils 8.30 on Fedora 29, btw., not same ancient
prehistoric software.

        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Reply via email to