Hi David, Andrea,
On 7/2/19 3:46 PM, David Malcolm wrote:
On Wed, 2019-06-26 at 15:05 +0000, Andrea Corallo wrote:
> David Malcolm writes:
>
> > On Tue, 2019-06-25 at 08:11 +0000, Andrea Corallo wrote:
> > > Hi,
> > > third version for this patch with the simplified test.
> > >
> > > make check-jit pass clean
> > >
> > > Bests
> > > Andrea
> > >
> > > 2019-06-09 Andrea Corallo andrea.cora...@arm.com
> > >
> > > * libgccjit.c (gcc_jit_context_new_binary_op): Check result_type
> > > to
> > > be a
> > > numeric type.
> > >
> > >
> > > 2019-06-20 Andrea Corallo andrea.cora...@arm.com
> > >
> > > * jit.dg/test-error-gcc_jit_context_new_binary_op-bad-res-type.c:
> > > New testcase.
> >
> > Thanks for the updated patch.
> >
> > This is good for trunk.
> >
> > (Copying and pasting from my other review): are you working on
> > getting
> > SVN commit access, or do you want me to commit your two patches on
> > your
> > behalf?
> >
> > Thanks
> > Dave
>
> Hi David,
> I can work on to get the SVN commit access.
> As a maintainer has to sponsor it would you mind being the one?
https://www.gnu.org/software/gcc/svnwrite.html says:
"a well-established GCC maintainer (including reviewers) can approve
for write access any person with GNU copyright assignment papers in
place and known to submit good patches."
Thanks for your patches so far.
I approve of you getting "Write after approval" access to GCC svn,
provided the copyright assignment paperwork is in place (which I'm
assuming is, based on your @arm.com email address).
I'm not quite sure what the next steps are.
It means Andrea needs to fill out the form at
https://sourceware.org/cgi-bin/pdw/ps_form.cgi with his SSH key and
putting your address as an approver. You'll then get a request to
approve it.
Cheers,
Kyrill
Dave
