On Tue, Aug 20, 2019 at 04:05:40PM -0400, Hans-Peter Nilsson wrote: > On Tue, 20 Aug 2019, Jose E. Marchesi wrote: > > > On Thu, Aug 15, 2019 at 12:22:46AM +0200, Jose E. Marchesi wrote: > > > > --- a/configure > > > > +++ b/configure > > Yeah by mistake I used a Debian patched autoconf 2.96. Will regenerate > > using vanilla autoconf for subsequent versions of the patch. > > It's nice that this is identified and hopefully resolved, but > since nobody mentioned it I'll just point out that > it's preferable to *not at all* include generated files like > configure in patches. See > <https://gcc.gnu.org/contribute.html#patches>.
"Do not include generated files as part of the patch, just mention them in the ChangeLog (e.g., "* configure: Regenerate.")." That's not common practice nowadays I think? It's also not good advice for people who might get it wrong. Also, the patches on the mailing list should preferably be exactly what is committed. For sanity. Segher
