On 8/30/19 4:11 AM, Jozef Lawrynowicz wrote:
> The attached patch removes hard-coded warnings from msp430 attribute handlers,
> and replaces them with exclusion rules specified in the attribute_spec table.
>
> Where msp430 attributes conflict with generic attributes, hard-coded warnings
> are still necessary.
>
>
> 0002-MSP430-Setup-exclusion-tables-for-function-and-data-.patch
>
> From c6def571a47df5394ca9f5c5c4918f0ffcf97375 Mon Sep 17 00:00:00 2001
> From: Jozef Lawrynowicz <joze...@mittosystems.com>
> Date: Wed, 28 Aug 2019 17:44:16 +0100
> Subject: [PATCH 2/3] MSP430: Setup exclusion tables for function and data
> attributes
>
> gcc/ChangeLog:
>
> 2019-08-29 Jozef Lawrynowicz <joze...@mittosystems.com>
>
> * config/msp430/msp430.c (msp430_attr): Remove warnings about
> conflicting msp430-specific attributes.
> (msp430_section_attr): Likewise.
> Add warnings about conflicts with generic "noinit" and "section"
> attributes.
> Fix grammar in -mlarge error message.
> (msp430_data_attr): Rename to msp430_persist_attr.
> Add warnings about conflicts with generic "noinit" and "section"
> attributes.
> Add warning for when variable is not initialized.
> Chain conditionals which prevent the attribute being added.
> (ATTR_EXCL): New helper.
> (attr_reent_exclusions): New exclusion table.
> (attr_naked_exclusions): Likewise.
> (attr_crit_exclusions): Likewise.
> (attr_lower_exclusions): Likewise.
> (attr_upper_exclusions): Likewise.
> (attr_either_exclusions): Likewise.
> (attr_persist_exclusions): Likewise.
> (msp430_attribute_table): Update with exclusion rules.
> (msp430_output_aligned_decl_common): Don't output common symbol if decl
> has a section.
>
> gcc/testsuite/ChangeLog:
>
> 2019-08-29 Jozef Lawrynowicz <joze...@mittosystems.com>
>
> * gcc.target/msp430/data-attributes-2.c: New test.
> * gcc.target/msp430/function-attributes-4.c: Update dg-warning
> strings.
> * gcc.target/msp430/region-attribute-misuse.c: Likewise.
>
OK
jeff
