On 9/30/19 2:45 PM, co...@sdf.org wrote: > On Mon, Sep 30, 2019 at 11:46:24AM -0400, Vladimir Makarov wrote: >> Yes, the patch is mostly ok. You can commit it into the trunk after >> applying changes mentioned below. If you do not have a write access, let me >> know I'll commit the patch by myself. > > I don't have commit access. It would be nice if you committed it :) I took care of the nits and committed the patch.
> >> It would be nice to add a small test too. But it is not obligatory for this >> case as the patch is obvious and it might be hard to create a small test to >> reproduce the bug. > > I have the C code that produces this failure. I can creduce it, but I'm > not sure there's a relationship between it and the bug. > Doing unrelated changes (adding instruction scheduling) to vax also hid it. > > Is this kind of test still valuable? Often they are. jeff
