On 11/4/19 3:03 PM, Aldy Hernandez wrote:
When I added the range-ops code, I had to teach vrp_val_is*{min,max}
about pointers, since it would just ignore them and return NULL. I was
overly cautious about changing existing behavior and decided to add a
handle_pointers argument, with a default value of FALSE, and just
changed the needed callers on a need-to basis.
Little by little we've been changing every caller to TRUE, and it's
becoming increasingly obvious that we should always handle pointers.
I can't think of a reason why we wouldn't want to handle them, and if
there is ever one, surely the caller can avoid calling these functions.
OK for trunk?
I thought it was weird initially anyway.. why wouldn't we handle
pointers :-) Furthermore, if we didn't want to handle them for some
reason, the call site would be the place to deal with it.
Approved assuming no regressions.
Andrew
