On Fri, Nov 08, 2019 at 11:17:21AM +0100, Tobias Burnus wrote:
> >     Jim MacArthur  <jim.macart...@codethink.co.uk>
> >     Mark Eggleston  <mark.eggles...@codethink.com>
> > 
> >     * arith.c (hollerith2representation): Use OPT_Wcharacter_truncation
> > in
> >     call to gfc_warning.  Add character2representation,
> > gfc_character2int,
> >     gfc_character2real, gfc_character2complex and gfc_character2logical.

This broke bootstrap:
../../gcc/fortran/arith.c: In function ‘void 
character2representation(gfc_expr*, gfc_expr*)’:
../../gcc/fortran/arith.c:2549:17: error: comparison of integer expressions of 
different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} 
   for (i = 0; i < MIN (result_len, src_len); i++)

I have committed the following patch to unbreak it as obvious.
Also, the ChangeLog entry has various issues.  When adding new functions
or prototypes etc., it should be
        (character2representation, gfc_character2int, gfc_character2real,
        gfc_character2complex, gfc_character2logical): New.
(or New functions., New declarations., Declare. etc.), not Add ...
Always what has changed and what was the change.

> >     * invoke.texi: Add option to list of options.
> >     * invoke.texi: Add Character conversion subsection to Extensions
> >     section.

The same file shouldn't be listed multiple times in the same ChangeLog
entry, multiple changes should be merged together, plus it would be helpful
to say what option has been added, etc.

> >     * lang.opt: Add new option.

Here it should be even * lang.opt (fdec-char-conversions): New option.
or so.


Reply via email to