On Fri, Nov 8, 2019 at 9:02 AM Eduard-Mihai Burtescu <ed...@lyken.rs> wrote: > > Ping #2 for https://gcc.gnu.org/ml/gcc-patches/2019-10/msg01830.html > Original patch (without the early exit optimization): > https://gcc.gnu.org/ml/gcc-patches/2019-10/msg01591.html
Sorry for letting this slide. Do we need the CHECK_OR and ERROR_AND macros? Is there anything like those elsewhere in the libiberty or GCC sources? I would rather than have ordinary code than obscure macros. Ian > On Wed, Oct 30, 2019, at 6:46 PM, Eduard-Mihai Burtescu wrote: > > Ping: https://gcc.gnu.org/ml/gcc-patches/2019-10/msg01830.html > > Original patch (without the early exit optimization): > > https://gcc.gnu.org/ml/gcc-patches/2019-10/msg01591.html > > > > Thanks, > > - Eddy B. > > > > On Fri, Oct 25, 2019, at 3:44 PM, Eduard-Mihai Burtescu wrote: > > > > This can be further optimized by using memcmp in place of strncmp, > > > > since from > > > > the length check you know that you won't see the null terminator among > > > > the three > > > > chars you're checking. > > > > > > Fair enough, here's the combined changelog/diff, with memcmp:
