Joseph Myers <jos...@codesourcery.com> wrote:

On Mon, 18 Nov 2019, Joseph Myers wrote:

On Sat, 16 Nov 2019, Iain Sandoe wrote:

Joseph Myers <jos...@codesourcery.com> wrote:

This patch adds support for the C2x [[]] attribute syntax to the C
front end.

gcc.dg/gnu2x-attrs-1.c: New tests.

This test fails on targets without symbol alias support, but it would
be most unfortunate to skip it entirely with the usual dg-requires.

In this instance, I propose to expect the error for Darwin as per the patch
below, but open to other suggestions, if you prefer something different.

OK / something else?

This patch is OK.

Actually, the committed change has incorrect syntax so causes

FAIL: gcc.dg/gnu2x-attrs-1.c *-*-darwin* (test for errors, line 8)

everywhere that's not Darwin.  You're putting "*-*-darwin*" in the "string
that forms part of the test name" slot, when you need to put something
else in that slot and then have { target *-*-darwin* } in the following
slot.

yes, the goof was spotted, and will be fixed shortly.

sorry,
Iain

Reply via email to