On Thu, 21 Nov 2019, Tamar Christina wrote: > Hi Joseph, > > > FE_TONEAREST is the default rounding mode, so it would be better just to > > remove the fesetround call and <fenv.h> include and fenv effective-target > > and -frounding-math option and let this test run for all configurations with > > int128 support. > > > > Hmm right, doing makes the execution of the test fail. > I'll investigate the failures and send a patch to remove the fenv together. > > Or do you want me to send them separately?
I think it's best to fix the test now not to have the #ifdef, then if you have execution failures those can be addressed separately. (If you want to avoid the test FAILing before then, an XFAIL with a comment referencing an open bug in Bugzilla would be appropriate, not #ifdef that makes the test spuriously PASS.) -- Joseph S. Myers jos...@codesourcery.com
