Hi Andrew! Sorry for the delay.
On 2019-11-14T16:36:38+0000, Andrew Stubbs <a...@codesourcery.com> wrote:
> This patch adds some necessary bits to enable OpenACC testings for
> amdgcn offloading.
Generally, I'm in favor if you'd consider such a thing (that in principle
is just a copy/adapt of the existing cases) as obvious to commit (even
more so with your "amdgcn port" maintainer hat on), especially so given
that this has been/is blocking you, as Tobias told me more than once.
That said:
> --- a/libgomp/testsuite/lib/libgomp.exp
> +++ b/libgomp/testsuite/lib/libgomp.exp
> @@ -316,6 +316,9 @@ proc offload_target_to_openacc_device_type {
> offload_target } {
> nvptx* {
> return "nvidia"
> }
> + amdgcn* {
> + return "gcn"
> + }
> default {
> error "Unknown offload target: $offload_target"
> }
Maintain alphabetical sorting?
> @@ -444,3 +447,28 @@ proc check_effective_target_hsa_offloading_selected {} {
> check_effective_target_hsa_offloading_selected_nocache
> }]
> }
> +# Return 1 if at least one AMD GCN board is present.
Missing vertical space?
> +proc check_effective_target_openacc_amdgcn_accel_present { } {
> +proc check_effective_target_openacc_amdgcn_accel_selected { } {
I'd also have inserted these maintaining alphabetical sorting, but I see
the existing other stuff also doesn't, so no need to bother.
For all the following three:
> --- a/libgomp/testsuite/libgomp.oacc-c++/c++.exp
> +++ b/libgomp/testsuite/libgomp.oacc-c++/c++.exp
> @@ -106,6 +106,9 @@ if { $lang_test_file_found } {
>
> set acc_mem_shared 0
> }
> + gcn {
> + set acc_mem_shared 0
> + }
> default {
> error "Unknown OpenACC device type: $openacc_device_type
> (offload target: $offload_target)"
> }
> --- a/libgomp/testsuite/libgomp.oacc-c/c.exp
> +++ b/libgomp/testsuite/libgomp.oacc-c/c.exp
> @@ -69,6 +69,9 @@ foreach offload_target [concat [split $offload_targets ","]
> "disable"] {
>
> set acc_mem_shared 0
> }
> + gcn {
> + set acc_mem_shared 0
> + }
> default {
> error "Unknown OpenACC device type: $openacc_device_type (offload
> target: $offload_target)"
> }
> --- a/libgomp/testsuite/libgomp.oacc-fortran/fortran.exp
> +++ b/libgomp/testsuite/libgomp.oacc-fortran/fortran.exp
> @@ -94,6 +94,9 @@ if { $lang_test_file_found } {
>
> set acc_mem_shared 0
> }
> + gcn {
> + set acc_mem_shared 0
> + }
> default {
> error "Unknown OpenACC device type: $openacc_device_type
> (offload target: $offload_target)"
> }
..., maintain alphabetical sorting, and please also include the
'untested' check/skip, as done in the 'nvidia' cases.
To record the review effort, please include "Reviewed-by: Thomas Schwinge
<tho...@codesourcery.com>" in the commit log, see
<https://gcc.gnu.org/wiki/Reviewed-by>.
Grüße
Thomas
signature.asc
Description: PGP signature
