Hi Thomas, On 10.12.19 15:44, Thomas Schwinge wrote:
>> Frederik Harwath (2): >> Use clause locations in OpenACC nested reduction warnings >> Add tests to verify OpenACC clause locations > > I won't insist, but suggest (common practice) to merge that into one > patch: bug fix plus test cases, using the summary line of your first > patch.> [...] > It's of course always OK to add new test cases, but wouldn't the same > test coverage be reached by just adding such checking to the existing > test cases in 'c-c++-common/goacc/nested-reductions-warn.c', > 'gfortran.dg/goacc/nested-reductions-warn.f90'? Sure, we could have everything in one patch and one test. The rationale for splitting the patches and for splitting the tests is that the tests do not try to verify the nested reductions validation code. They try to verify that the language front-ends set the correct locations for clauses. Without a possibility to do proper unit testing, I just had to find some way to check the clauses. I had no immediate success triggering one of the very few other warnings that use the location of omp_clauses from both Fortran and C code and hence I went with the nested reductions code. Thanks for your review! Best regards, Frederik
