Hi all, On 12/11/19 9:41 AM, Stam Markianos-Wright wrote:
On 12/11/19 3:48 AM, Jeff Law wrote: > On Mon, 2019-12-09 at 13:40 +0000, Stam Markianos-Wright wrote: >> >> On 12/3/19 10:31 AM, Stam Markianos-Wright wrote: >>> >>> On 12/2/19 9:27 PM, Joseph Myers wrote: >>>> On Mon, 2 Dec 2019, Jeff Law wrote: >>>> >>>>>> 2019-11-13 Stam Markianos-Wright < >>>>>> stam.markianos-wri...@arm.com> >>>>>> >>>>>> * real.c (struct arm_bfloat_half_format, >>>>>> encode_arm_bfloat_half, decode_arm_bfloat_half): New. >>>>>> * real.h (arm_bfloat_half_format): New. >>>>>> >>>>>> >>>>> Generally OK. Please consider using "arm_bfloat_half" instead >>>>> of >>>>> "bfloat_half" for the name field in the arm_bfloat_half_format >>>>> structure. I'm not sure if that's really visible externally, >>>>> but it >>> Hi both! Agreed that we want to be conservative. See latest diff >>> attached with the name field change (also pasted below). >> >> .Ping :) > Sorry if I wasn't clear. WIth the name change I considered this OK for > the trunk. Please install on the trunk. > > If you don't have commit privs let me know. Ahh ok gotcha! Sorry I'm new here, and yes, I don't have commit privileges, yet!
I've committed this on Stams' behalf with r279216. Thanks, Kyrill
Cheers, Stam > > > Jeff >
