Andrew Pinski <andrew.pin...@caviumnetworks.com> writes: >> gcc/ChangeLog: >> * mips/mips-cpus.def (octeon+): New CPU.
config/mips/mips-cpus.def >> testsuite/ChangeLog: >> * gcc.target/mips/mult-1.c: Forbit all Octeon processors. Forbid. > @@ -1,6 +1,6 @@ > /* For SI->DI widening multiplication we should use DINS to combine the two > halves. For Octeon use DMUL with explicit widening. */ > -/* { dg-options "-O -mgp64 isa_rev>=2 forbid_cpu=octeon" } */ > +/* { dg-options "-O -mgp64 isa_rev>=2 forbid_cpu=octeon\[\+0-9\]*" } */ > /* { dg-final { scan-assembler "\tdins\t" } } */ > /* { dg-final { scan-assembler-not "\tdsll\t" } } */ > /* { dg-final { scan-assembler-not "\tdsrl\t" } } */ Here I'd either prefer "forbid_cpu=octeon.*" (a bold statement that no Octeon processor will ever be interested in these tests) or "forbid_cpu=octeon(|+|2)" (a much more focused statement). Just matching + and numbers is a bit in the middle: past experience suggests that marketing departments don't always follow such logic. If you don't have a strong preference, let's go for (|+|2). If you do, go with what you think's best. OK for 4.7 with those changes, thanks. Richard