On Fri, Jan 17, 2020 at 11:12:08AM +0000, Mihail Ionescu wrote:
> On 01/17/2020 08:37 AM, Jakub Jelinek wrote:
> > On Wed, Dec 18, 2019 at 05:00:01PM +0000, Mihail Ionescu wrote:
> > > 2019-12-18 Mihail Ionescu <mihail.ione...@arm.com>
> > > 2019-12-18 Andre Vieira <andre.simoesdiasvie...@arm.com>
> > >
> > > * config/arm/arm-cpus.in (mve, mve_float): New features.
> > > (dsp, mve, mve.fp): New options.
> >
> > Note, the above is not the right ChangeLog formatting when you have more
> > than one author. The date should be there only for the first line, for the
> > other authors there should be just tab and 4 spaces, otherwise various tools
> > that parse ChangeLog entries will be quite confused. So like:
> > 2019-12-18 Mihail Ionescu <mihail.ione...@arm.com>
> > Andre Vieira <andre.simoesdiasvie...@arm.com>
> >
> > I've fixed your commits in 2b3534a3122236d6317256f16daa332278391907
> > but please remember this next time.
>
> Thank you, I did not realise that I wasn't using the correct formatting
> style. I'll keep that in mind for next time.
Two more things.
One is I wonder if it has been bootstrapped, because at least in a cross
from x86_64-linux to armv7hl-linux-gnueabi I'm seeing:
../../gcc/config/arm/arm.c: In function ‘void
cmse_nonsecure_call_inline_register_clear()’:
../../gcc/config/arm/arm.c:18469:18: warning: unused variable ‘next’
[-Wunused-variable]
rtx_insn *next, *last, *pop_insn, *after = insn;
^~~~
warning, which I believe in bootstrap would result in
-Werror=unused-variable error.
The variable is really unused, so I've checked in as obvious following
patch.
The other thing is that https://gcc.gnu.org/codingconventions.html and
https://www.gnu.org/prep/standards/standards.html#Formatting say that
rtx tmp =
copy_to_suggested_reg (XEXP (operands[0], 0),
gen_rtx_REG (SImode, R4_REGNUM),
SImode);
etc. I've seen in your patch is not correctly formatted, the =
should not be at the end of line (similarly to |, &, ||, &&, +, -,
etc.), but should be at the start of the next line.
That would be then
rtx tmp
= copy_to_suggested_reg (XEXP (operands[0], 0),
gen_rtx_REG (SImode, R4_REGNUM),
SImode);
but the line is really short, so I don't see a point to break line there at
all, you can just use:
rtx tmp = copy_to_suggested_reg (XEXP (operands[0], 0),
gen_rtx_REG (SImode, R4_REGNUM),
SImode);
2020-01-17 Jakub Jelinek <ja...@redhat.com>
* config/arm/arm.c (cmse_nonsecure_call_inline_register_clear): Remove
unused variable.
--- gcc/config/arm/arm.c.jj 2020-01-17 09:31:28.594195284 +0100
+++ gcc/config/arm/arm.c 2020-01-17 19:30:47.747756756 +0100
@@ -18466,7 +18466,7 @@ cmse_nonsecure_call_inline_register_clea
if (TARGET_HAVE_FPCXT_CMSE)
{
- rtx_insn *next, *last, *pop_insn, *after = insn;
+ rtx_insn *last, *pop_insn, *after = insn;
start_sequence ();
Jakub
