On Jan 24, 2020, at 9:45 AM, David Edelsohn <dje....@gmail.com> wrote: > > On Fri, Jan 24, 2020 at 12:00 PM Jason Merrill <ja...@redhat.com> wrote: >> >> On 1/24/20 8:45 AM, David Edelsohn wrote: >>> There is no ChangeLog entry for the testsuite changes. >> >> I don't believe in ChangeLog entries for testcases, but I'll add one for >> the target-supports.exp change, thanks. > > Is this a general policy change that we want to make? Current we > still have gcc/testsuite/ChangeLog and developers are updating that > file.
I kinda like the current policy. Use it if you want to, but, you can't count on others to use it. I'd say this is a slight preference of mine. Personally, I find git log <testcase>, to be easier, faster, more accurate, can't go wrong. With that, I'd usually only go to ChangeLog for commentary, though, since the changelog entry should be into the git log entry, git log is still sufficient to get at the commentary. The only reason why git log works in this case, is because a single test case is in a single file with usually no or very little intermixing. This isn't true of expression.c for example. In the git log for expr.c, you'd have to wade through a ton of chaff, which makes it much harder to use in some situations. For the testsuite/lib/* files, I actually prefer ChangeLog entries (to match the policy of gcc/*.c). This isn't policy, but, I'd encourage others in this direction. I suppose I like ChangeLogs for all the *.exp files as well, as usually these are for a large multitude of test cases. That's just my $0.02. If others want to chime in, on what the like and why...
