在 2020/3/5 下午10:18, Iain Sandoe 写道:
Hello JunMa,

JunMa <ju...@linux.alibaba.com> wrote:

Ping

Once again, sorry for taking time to review this.

在 2020/2/27 上午10:18, JunMa 写道:
在 2020/2/11 上午10:14, JunMa 写道:
Kindly ping

Regards
JunMa
Hi
In maybe_promote_captured_temps, the cleanup_point_stmt has been
stripped when handle temporaries captured by reference. However, maybe
there are non-reference temporaries in current stmt which cause ice in
gimpilify pass.

This patch fix this. The testcase comes from cppcoro and is reduced by
creduce.

With current trunk + Bin’s two approved patches.

I see no change in the testcase (lambda-09-capture-object.C) before / after the patch
 (it fails for me at -O0 only - in both cases).

please could you check?
As I said at previous mail, this patch fix the ICE in gimpilify pass.

I test with current trunk + Bin's two patches, the testcase passes with the patch and fails without the patch. It also fix co-await-syntax-11.C which caused by same ICE.

could you do double check?

Regards
JunMa
thanks
Iain


Reply via email to