On Thu, 2 Apr 2020 at 17:16, Martin Liška <mli...@suse.cz> wrote: > > Hi. > > The patch compares type attributes for gimple_call_fntypes in IPA ICF. > Note that we were unable to find a generic function attribute that > can be used on a function type definition. > > For a one which is allowed assume_aligned(16) I get affects_type_identity == > false > which seems suspicious to me. > > Note that we currently use comp_type_attributes in ICF for both variable and > function declarations. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin >
Hi, Thanks for the quick patch! I confirm it fixes the problem I noticed on arm with the cmse-15.c for -O2 and -O3. However, the testcase still fails with -Os. I haven't looked at the details, so it may be a different cause. Thanks, Christophe > gcc/ChangeLog: > > 2020-04-02 Martin Liska <mli...@suse.cz> > > PR ipa/94445 > * ipa-icf-gimple.c (func_checker::compare_gimple_call): > Compare type attributes for gimple_call_fntypes. > --- > gcc/ipa-icf-gimple.c | 4 ++++ > 1 file changed, 4 insertions(+) > >
