Hi Tobias! On 2020-04-08T09:55:24+0200, Tobias Burnus <tob...@codesourcery.com> wrote: > I have now committed this patch > as r10-7614-g13e41d8b9d3d7598c72c38acc86a3d97046c8373, > reading "so we shall accept it" as approval …
That's OK. As I said: "I'm not at all familiar with the front ends' scoping implementation", and don't currently have time to learn about that. So, either you're confident that you're doing the right things there (which I shall assume, given that you didn't explicitly ask whether you're doing the right things), or you need to wait for somebody else to review the patch. Reviewers don't know everything -- certainly I don't ;-) -- and don't have bandwidth to learn everything. And even if a proper review is done, often enough the reviewer fails to foresee the one detail that should've been caught. Hence, I'm happy to incrementally improve things, as long as a patch isn't regressing any (or, too many) other things, and isn't conceptually questionable (both of which doesn't apply here). That's why I said "we shall accept [the patch]" -- meaning "approved for commit, without my proper review". Grüße Thomas ----------------- Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter
