Am 19.04.20 um 20:03 schrieb José Rui Faustino de Sousa via Fortran:
Hi Thomas!
> ? In other words, maybe a check on the upper bound
> of the last dimension would be better?
>
You mean enforcing:
C928 (R921) The second subscript shall not be omitted from a
subscript-triplet in the last dimension of an assumed-size array.
right?
If I have correctly understood the way things are done this is a more
general test which is already done at resolve.c around line 4690.
I just checked that it works, so I think this is fine. It looks
like assumed_size_refs_4.f90 already checks for that, so that is
fine.
Other than that, a couple of points:
The style you used for your patch,
+ if (upper
+ && type == AR_FULL
+ && as
+ && as->type == AS_ASSUMED_SIZE)
doesn't conform to the GNU style guidelines. This should go on one
line (as long as it fits).
Also, I could not apply your patch via copy & paste from the text of
the e-mail. Could you send patches as an attachment in the future?
Due do some unfortunate limitations of the current mailing list
software, it is probably best if you send it as a *.txt file.
So, OK for trunk with the cosmetic corrections above.
Thanks a lot for the patch, and welcome aboard!
> A question: Do you have a copyright assignment yet?
>
Yes, I have already done that.
Excellent.
Best regards
Thomas
