Re: [PATCH] amdgcn: Add stub personality function

[Kwok Cheung Yeung]

On 23/04/2020 12:05 pm, Thomas Schwinge wrote:
So we should simply disable it properly (see below)...
... instead of adding such stub functions.


I suggest we instead apply what I'd proposed a month ago in
<https://gcc.gnu.org/PR94282> "[amdgcn] ld: error: undefined symbol:
__gxx_personality_v0", and now yesterday (coincidentally) posted.

     +static enum unwind_info_type
     +gcn_except_unwind_info (struct gcc_options *opts ATTRIBUTE_UNUSED)
     +{
     +  return UI_NONE;
     +}

     +#undef  TARGET_EXCEPT_UNWIND_INFO
     +#define TARGET_EXCEPT_UNWIND_INFO gcn_except_unwind_info


I agree that not generating the problematic code in the first place is the 
better approach. Does that mean we can now remove libgcc/config/gcn/unwind-gcn.c 
completely?

Thanks

Kwok