On 21/04/2020 13:24, Thomas Schwinge wrote:
I wondered whether for symmetry, the GCC-internal 'GOMP_DEVICE_GCN', 'OFFLOAD_TARGET_TYPE_GCN' should also be renamed to '*_RADEON'? Or, going by example of '*_NVIDIA_PTX', name them '*_AMD_GCN'. Or, in fact then leave them as '*_GCN', given Julian's point in another thread that "CPU architectures or core implementations [sometimes shift] company allegiance". Thank you for listening to me thinking aloud. ;-)
I don't think the GCC internal names need to change. The port name is now "gcn", and the target name "amdgcn". I don't think we need a third name for it!
But more importantly, what about the user-visible 'gcn' in the 'ACC_DEVICE_TYPE' environment variable? As I'd quoted in <http://mid.mail-archive.com/87blsqlre6.fsf@euler.schwinge.homeip.net>: | Per OpenACC 3.0, A.1.2. "AMD | GPU Targets", for example, there is 'acc_device_radeon' ... which you've addressed... | (and "the | case-insensitive name 'radeon' for the environment variable | 'ACC_DEVICE_TYPE'"). ..., but this not yet?
Oh, right, the user-visible case ought to accept "radeon", at least. :-(
Please see the attached "[AMD GCN] Use 'radeon' for the environment variable 'ACC_DEVICE_TYPE'", completely untested. Will you please test and review that? If approving this patch, please respond with "Reviewed-by: NAME <EMAIL>" so that your effort will be recorded in the commit log, see <https://gcc.gnu.org/wiki/Reviewed-by>.
This is OK, assuming it tests OK. Andrew
