On 5/11/20 5:21 AM, Segher Boessenkool wrote:
Hi!
On Sat, May 09, 2020 at 12:05:08PM -0500, Bill Schmidt wrote:
From: Carl Love <c...@us.ibm.com>
Add support for xxgenpcv[dw]m, along with individual and overloaded
built-in functions for access.
(xxgenpcvm_<mode>): New insn.
(xxgenpcvm<mode>): New expansion.
Eww. Let's please use or not use underscore in both cases. Insns that
are not created directly should have a name starting with *. We have
many examples of an expand with the same name as an insn (other than the
insn having a *), which isn't really confusing because the dexpand
usually is right before the insn.
But, in this case, you *do* call the insn directly (namely, from the
define expand!) So maybe use a "xxgenpcvm<mode>_internal" or similar
name for the define_insn?
Agreed. I'm fixing that now. Thanks!
Bill
Okay for trunk with that improved somehow. Thanks!
Segher
