Hi!
On Sat, May 16, 2020 at 09:46:15AM -0500, Peter Bergner wrote:
> On 5/13/20 11:22 AM, Joel Brobecker wrote:
> > Would someone mind reviewing this patch, please?
> You should always CC the PPC maintainers on PPC patches.
> I've CC'd both Segher and David.
Thanks Peter. Yes, I hadn't seen this patch yet.
> >> On Fri, Apr 17, 2020 at 04:49:47PM -0700, Joel Brobecker wrote:
> >>> From: Douglas Rupp <r...@adacore.com>
> >>> We're getting an error when running this test on PowerPC VxWorks 7,
> >>> due to an unexpected warning:
> >>>
> >>> | Excess errors:
> >>> | cc1: warning: '-mvsx' and '-mno-altivec' are incompatible
> >>>
> >>> The warning comes from a combination of factors:
> >>> - The test itself uses -mvsx explicitly via the following directive:
> >>> // { dg-options "-O1 -mvsx" }
> >>> - Our toolchain was configured so as to make -mno-altivec
> >>> the default;
> >>> - These two options are mutually exclusive.
If the CPU does not allow -mvsx, this should just fail, saying that. If
the CPU does allow -mvsx, it should override the earlier option, so you
should end up with everything enabled.
So it sounds like we have some problems here :-/
> >>> This commit adds a powerpc_vsx_ok dg-require-effective-target directive
> >>> to that test, and thus making it UNSUPPORTED instead.
> >>> * gcc.target/powerpc/pr71763.c: Require powerpc_vsx_ok.
Ah, I see.
> >>> OK for master?
Yes. Also okay for backports (8, 9, 10).
Thanks!
(Don't forget the changelog?)
Segher
> >>> diff --git a/gcc/testsuite/gcc.target/powerpc/pr71763.c
> >>> b/gcc/testsuite/gcc.target/powerpc/pr71763.c
> >>> index b36ddfa26b0..b8888394393 100644
> >>> --- a/gcc/testsuite/gcc.target/powerpc/pr71763.c
> >>> +++ b/gcc/testsuite/gcc.target/powerpc/pr71763.c
> >>> @@ -1,5 +1,6 @@
> >>> // PR target/71763
> >>> // { dg-do compile }
> >>> +// { dg-require-effective-target powerpc_vsx_ok }
> >>> // { dg-options "-O1 -mvsx" }
> >>>
> >>> int a, b;
