On Mon, May 18, 2020 at 01:00:01PM +0200, Martin Liška wrote: > On 5/18/20 12:41 PM, Jakub Jelinek wrote: > > On Mon, May 18, 2020 at 12:37:58PM +0200, Martin Liška wrote: > > > The patch adds new no_stack_protect attribute. The change is requested > > > from kernel folks and is direct equivalent of Clang's no_stack_protector. > > > Unlike Clang, I chose to name it no_stack_protect because we already > > > have stack_protect attribute (used with -fstack-protector-explicit). > > > > Wouldn't it be better to look at the optimize attribute to see if it really > > does what has been said in the thread and if we don't want to change it, > > such that a function with optimize attribute xyz stands for the option > > defaults + command line options + xyz, rather than option defaults + xyz > > only? > > It's documented behavior what we do: > > ``` > The optimize attribute is used to specify that a function is to be compiled > with different optimization options than specified on the command line. > ``` > > It's pretty clear about the command line arguments (that are ignored).
That is not clear at all. The difference is primarily in what the option string says in there. Jakub